Fix DailyQuestSystem quest replenishment and TestQuestFactory creation - #24
Merged
Red-Cat-Fat merged 2 commits intoFeb 13, 2026
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Red-Cat-Fat
merged commit Feb 13, 2026
de0db5f
into
codex/add-tests-for-all-packages-in-github-actions
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DailyQuestSystemwithLoadData(QuestsDataContainer.Empty)in the constructor so the active quest list is populated to the required count at creation. (updatedDailyQuestSystem.cs)UpdateQuestListto unsubscribe from events first and callDisable()only when the quest is stillInProgress, avoiding redundant state transitions for already skipped/finished/failed quests. (updatedDailyQuestSystem.cs)TestQuestFactory.MakeNewQuest(List<IQuest>)to delegate to the internal test queue methodMakeNewQuest()so test factory can supply quests to the system without throwingNotImplementedException. (updatedTestQuestFactory.cs)Testing
git commit,git show) and succeeded, and the changes were committed as part of a local commit.Codex Task